search

compSPI / ioSPI

I/O and Data Visualization
MIT License
4 stars 7 forks source link

Refactor datasets.py and update corresponding unit tests/tutorial notebook #89

Closed bongjinkoo closed 2 years ago

bongjinkoo commented 2 years ago

Description

This PR refactors datasets.py by making the upload/download pipeline consistent. Previously, uploading and downloading used different classes but now all the methods are in OSFProject class. Unit tests and tutorial notebook were updated accordingly.

Issue

74

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ninamiolane commented 2 years ago

Converting to draft: I will review when the github actions pass, can you mark as "ready for review" when that is the case (let me know if the osf not found problem persists?). Thanks 🙌

codecov[bot] commented 2 years ago

Codecov Report

Merging #89 (355146b) into master (f7bfde2) will increase coverage by 8.54%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   90.13%   98.66%   +8.54%     
==========================================
  Files           5        5              
  Lines         243      223      -20     
==========================================
+ Hits          219      220       +1     
+ Misses         24        3      -21
Impacted Files Coverage Δ
ioSPI/datasets.py 100.00% <100.00%> (+28.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7bfde2...355146b. Read the comment docs.