thisFreya commented 2 years ago

See https://github.com/compSPI/reconstructSPI/issues/13.

Gridding of SO(3) via randomly distributed rotations - a 3D rotation matrix is generated from geomstats..

Demonstration of functionality (in each image 1000 rotation matrices are applied to a cartesian axis unit vector and plotted). demo2

geoffwoollard commented 2 years ago

Oh good point I see the lint and test files are there in the github workflow folder... There just not in files changed since you are not merging into master, but back into itr_ref_docstrings. I suspect the tests would run if you tried to merge in to master

geoffwoollard commented 2 years ago

Hmmm why isn't the linting/testing workflow being triggered. Will close and reopen.

thisFreya commented 2 years ago

Hmmm why aren't the tests working. Will close and reopen.

@geoffwoollard For future reference in case this comes up again, the tests only run when changes to the code happen (e.g. changes in expectation_maximization.py) so when you change the base branch you can also just push a comment change or something afterward to get the tests to run.

geoffwoollard commented 2 years ago

@thisTyler please fix the linting and testing issues.

codecov[bot] commented 2 years ago

Codecov Report

Merging #28 (b251e5c) into dev (5a4ebb5) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head b251e5c differs from pull request most recent head f7baaa9. Consider uploading reports for the commit f7baaa9 to get more accurate results

@@            Coverage Diff            @@
##               dev       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          145       173   +28     
=========================================
+ Hits           145       173   +28

Impacted Files	Coverage Δ
...I/iterative_refinement/expectation_maximization.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a4ebb5...f7baaa9. Read the comment docs.

geoffwoollard commented 2 years ago

I'll merge since everything is passing tests. Better tests can live on in issue #39

compSPI / reconstructSPI

Uniform discritization of SO(3) via random rotation matrices #28

Codecov Report