search

compact / angular-bootstrap-lightbox

An AngularJS lightbox built using UI Bootstrap Modal.
http://compact.github.io/angular-bootstrap-lightbox/
MIT License
306 stars 134 forks source link

angular-bootstrap-lightbox.min.js is broken #1

Closed dsem closed 10 years ago

dsem commented 10 years ago

The provided angular-bootstrap-lightbox.min.js is broken. Using this file as the lightbox src produces the following error when you inject Tabletop into a controller:

Error: [$injector:unpr] http://errors.angularjs.org/1.2.18/$injector/unpr?p0=aProvider%20%3C-%20a%20%3C-%20Lightbox%20%3C-%20imageSliderDirective
    at Error (native)
    at http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:6:450
    at http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:36:145
    at Object.c [as get] (http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:34:236)
    at http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:36:213
    at c (http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:34:236)
    at Object.d [as invoke] (http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:34:453)
    at http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:36:231
    at c (http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:34:236)
    at Object.d [as invoke] (http://ajax.googleapis.com/ajax/libs/angularjs/1.2.18/angular.min.js:34:453)

Switching to angular-bootstrap-lightbox.js resolves this issue.

compact commented 10 years ago

Thanks, angular-bootstrap-lightbox.min.js should work properly now (I forgot to use ngmin). Let me know if it doesn't.