search

compact / angular-bootstrap-lightbox

An AngularJS lightbox built using UI Bootstrap Modal.
http://compact.github.io/angular-bootstrap-lightbox/
MIT License
306 stars 134 forks source link

Is it possible video (mp4, webm) #27

Closed lanceschi closed 8 years ago

lanceschi commented 8 years ago

I would like to use video sources too. Like Mp4 and webm. Do you have any plan to encompass it?

Nice piece of software btw!

Cheers, Luca

jakeandliss commented 8 years ago

+1

compact commented 8 years ago

There is support for using ng-videosharing-embed to embed external videos from YouTube, Vimeo, etc.

Are both of you looking to embed your own videos directly? Is there a specific Angular video library/player that you would want to use to do this?

lanceschi commented 8 years ago

@compact yes, I'm interested in local video files (Mp4 and WebM).

A simple HTML

Maybe a yield/delegate HTML block is to be considered in your angular-bootstrap-lightbox for handling local video.

Thanks

compact commented 8 years ago

I added a <video> to the default template for embedding mp4/webm/ogg files. Check the videos demo. It has controls and autoplay enabled. To customize this (maybe you want both an .mp4 and a .webm as sources for one video), you can create a custom template.

I think for MediaElement.js, a custom template makes more sense than adding it to the default template.

lanceschi commented 8 years ago

@compact brilliant! I just made a quick test with mp4 and webm files with the basic <video> HTML tag and everything works flawlessly as expected. Thanks. :+1: