compact / angular-bootstrap-lightbox

An AngularJS lightbox built using UI Bootstrap Modal.
http://compact.github.io/angular-bootstrap-lightbox/
MIT License
306 stars 134 forks source link

isVideo error when passing image name string #29

Closed irokhes closed 8 years ago

irokhes commented 8 years ago

Hi,

I'm starting to use the ligthbox, I tried to create a quick sample, passing the image url to the lightbox instead a complex object, but I'm getting and error with the function isVideo, trying to check the image.type. Does it mean that the image needs to be a complex object containing a type always?

Thanks!

P.S great work!!

compact commented 8 years ago

No, I think I have fixed that error.

If you mean passing into Lightbox.openModal(), the first argument has to be an array of strings (urls) or objects.

I made an update where you no longer have to configure the provider in order for the string urls to work. See this demo for an example (ignore the fullScreenMode).