search

compact / angular-bootstrap-lightbox

An AngularJS lightbox built using UI Bootstrap Modal.
http://compact.github.io/angular-bootstrap-lightbox/
MIT License
306 stars 134 forks source link

Mark as template #33

Open Ryuno-Ki opened 8 years ago

Ryuno-Ki commented 8 years ago

In order to properly load lightbox.html it was necessary to us, to wrap the markup in

<script type="text/ng-template" id="lightbox.html">
/* Content of lightbox.html goes here */
</script>

Maybe you can add those lines on your own :)

compact commented 8 years ago

This should not be necessary because the template is stored in the $templateCache, so Angular knows what lightbox.html is. Can you provide more details about your usage?

Ryuno-Ki commented 8 years ago

Sorry, not a priority in our project. I'll read about $templateCache on the docs. We need a dedicated html file (for server side processing), so putting everything into the JavaScript file smells …

And in the docs, they have assigned an id as well ;-)

stodolos commented 8 years ago

I actually had a typo and all is good now. Thanks!

Chris

On Jan 12, 2016, at 12:39 PM, André Jaenisch notifications@github.com wrote:

Sorry, not a priority in our project. I'll read about $templateCache on the docs. We need a dedicated html file (for server side processing), so putting everything into the JavaScript file smells …

And in the docs, they have assigned an id as well ;-)

— Reply to this email directly or view it on GitHub.