search

companieshouse / api-enumerations

83 stars 35 forks source link

Missing enumeration for error type #59

Open rcocks opened 8 years ago

rcocks commented 8 years ago

A call to GET https://api.companieshouse.gov.uk/company/{company_number}/exemptions with a company with no exemptions or a company that does not exist returns an error company-exemptions-not-found. This error is not listed in errors.yml .

AntoCuc commented 7 years ago

Rather than returning an error. Or adding the error described by @rcocks to errors.yml shoudn't this service gracefully return a companyExceptions resource as described at https://developer.companieshouse.gov.uk/api/docs/company/company_number/exemptions/companyExemptions-resource.html with an empty list of exceptions?