search

company-mode / company-quickhelp

Documentation popup for Company
GNU General Public License v3.0
374 stars 33 forks source link

Use company-quickhelp face #87

Closed eigengrau closed 6 years ago

eigengrau commented 6 years ago

I notice I had this applied to my local fork for a while, marked WIP, but I can’t figure out what might possibly be missing. Maybe you’ll notice some reason why I haven’t PRed this yet.

expez commented 6 years ago

pos-tip has foreground and background color (that you can tweak) that controls the colors of the popup, globally.

That color overrides this, I'm guessing, which is why it doesn't work.

eigengrau commented 6 years ago

Sorry, I may have miscommunicated. The patch does indeed work. I was just suspecting there might be something I haven’t covered yet, e.g., some code-path that doesn’t use company-quickhelp--show. If that’s not the case we should be able to apply this.