companyinfo / helm-charts

Company.info Helm charts repository
https://companyinfo.github.io/helm-charts
Apache License 2.0
68 stars 22 forks source link

Support templates in ingress hostname and ingressClassName #18

Closed yahel2410 closed 1 year ago

yahel2410 commented 1 year ago

Also added to extraHosts. Tested that it renders with these values:

---
# values.yaml 
ingress:
  enabled: true
  path: /(api/marketplace.*)$
  hostname: "{{ .Values.global.apiHost }}"
  ingressClassName: "{{ .Values.global.ingressClassName }}"
  tls: true
  selfSigned: true
  extraHosts:
    - name: "{{ .Values.global.apiHost }}-2"
      path: /

---
# global.yaml
global:
  apiHost: "foo.bar.com"
  ingressClassName: "nginx"
atkrad commented 1 year ago

@yahel2410 Thanks for your contribution.

Please update the version and the appVersion fields in the Chart.yaml file:

version: "0.9.0"
appVersion: "0.9.0"
yahel2410 commented 1 year ago

@atkrad Thanks for the quick reply. Done