GUI: Streamline "generate invite"

companyzero / bisonrelay

ISC License

31 stars 13 forks source link

GUI: Streamline "generate invite" #618

Closed jzbz closed 2 weeks ago

jzbz commented 1 month ago

Right now generating an invite is a bit convoluted.

Generate invite.bin.
Key (brpik...) is displayed when complete.

There is no info given to the user about what to do with that data, intuitively is seems like you should send the generated .bin file to the person you wish to communicate with.

If the user has the .bin file and goes to "fetch invite" they are unable to continue if they do not also possess the brpik key.

A couple suggestions:

Do away with the bin files, only display the brpik key.
Also display the key as a QR code (assuming mobile app has camera support).
Tell the user to share that with their counterparty they wish to initiate communication with.

miki-totefu commented 1 month ago

If the user has the .bin file and goes to "fetch invite" they are unable to continue if they do not also possess the brpik key.

brpik key is not needed when sending the invite.bin file (invite.bin is sufficient).

using invite.bin file is slightly better for privacy because it hides the exchange of the initial invite between users from the server (everything is encrypted, but one user paying for fetching when another user actually fetches the RV is metadata that RV is likely an invite exchange)

QR code is already works on master

but the instructions on gui should be better to show either brpik or invite.bin file is needed (and not both)

jzbz commented 1 month ago

The problem is if you use an invite.bin and select it in the GUI you are not able to proceed unless you also paste in the brpik key, so it's requiring both right now when either should suffice.

As you can see you can't click "fetch invite" even though an invite.bin has been selected.