comparative-concepts / cc-database

Cross-linked database of Comparative Concepts, extracted from "Morphosyntax: constructions of the world's languages", by William Croft (2022)
https://comparative-concepts.github.io/cc-database/
4 stars 1 forks source link

Grow graph from selected nodes #11

Open heatherleaf opened 1 week ago

heatherleaf commented 1 week ago

Currently the Grow buttons (upwards, downwards, outwards) grow from all currently visible graph nodes.

It would be better to grow only from selected nodes.

Question to @wcroft : if no nodes are selected, should it still be possible to grow the graph (and then it would work as now)? Or should the Grow buttons be greyed out?

wcroft commented 1 week ago

I agree it would be better to grow only from selected nodes.

I think we should still allow growing the entire graph as it is now. But maybe for consistency (at least to the user), we could include a Select All button, and if the user wants to grow out the entire subgraph, they can Select All and then use the current Grow buttons. That way the user will always be growing from selected nodes.

heatherleaf commented 2 days ago

I agree that a Select All button is the best

heatherleaf commented 2 days ago

Added a button to select "all visible", and only grow from selected nodes, in https://github.com/comparative-concepts/cc-database/commit/40ad2d02e2189bd3fb13f82e628c40611354aff8