compas-dev / compas

Core packages of the COMPAS framework.
https://compas.dev/compas/
MIT License
309 stars 105 forks source link

include object's own frame #1379

Closed Licini closed 2 months ago

Licini commented 2 months ago

@tomvanmele I know we had some discussion on moving responsibility of handling transformation out of Scene. But before we actually do that, there was a mistake here to fix. The worldtransformation was not including the object's own frame. This PR is to fix that.

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.99%. Comparing base (ea316f9) to head (49130dd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1379 +/- ## ========================================== + Coverage 59.92% 59.99% +0.07% ========================================== Files 206 206 Lines 22136 22136 ========================================== + Hits 13264 13280 +16 + Misses 8872 8856 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Licini commented 2 months ago

LGTM. although would be nice if there were an example in the docs :)

Just updated the relevant section in the docs. Also added a test. btw what should I do to pass this codecov test??