Closed Licini closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 59.99%. Comparing base (
ea316f9
) to head (49130dd
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM. although would be nice if there were an example in the docs :)
Just updated the relevant section in the docs. Also added a test. btw what should I do to pass this codecov test??
@tomvanmele I know we had some discussion on moving responsibility of handling transformation out of Scene. But before we actually do that, there was a mistake here to fix. The
worldtransformation
was not including the object's own frame. This PR is to fix that.What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.