`compas_rhino.utilities.delete_layers` deletes whole tree when given dict as input.

tetov commented 3 years ago

Describe the bug

Unexpected behavior when using a dict as parameter for compas_rhino.utilities.delete_layer.

(I might be misunderstanding though, let me know if so and I can probably updated docstring)

To Reproduce

Environment

Rhino Python Editor

Sample script

from compas_rhino.utilities import create_layers, delete_layers
layers = {'COMPAS': {'layers': {'Datastructures': {'layers': {'Mesh': {}, 'Network': {}}}}}, "SAPMOC": {}}
create_layers(layers)
delete_layers({'COMPAS': {'layers': {'Datastructures': {'layers': {'Network': {}}}}}})

Result

Expected result

Other environment details

Desktop (please complete the following information):

OS: Windows 10
Python version: 2.7.8 (IronPython 2.7.8 (2.7.8.0) on .NET 4.0.30319.42000 (64-bit))
Python package manager: conda

tomvanmele commented 3 years ago

perhaps we should provide the option to delete "endpoints" only?

tetov commented 3 years ago

Maybe, but that can be done with "COMPAS::Datastructures::Network".. I think just making sure that the more specific the input is, the more specific the action is. If the dict given contains sublayers down to an endpoint only the endpoint is removed. If it stops before then the last points tree is removed.

compas-dev / compas