search

compas-dev / compas_cgal

COMPAS package for working with CGAL.
https://compas.dev/compas_cgal
GNU Lesser General Public License v3.0
23 stars 5 forks source link

compas_cgal.slicer.slice_mesh, open versus closed contours #3

Open ioannaMitropoulou opened 3 years ago

ioannaMitropoulou commented 3 years ago

Feature Request

As a user of the package, I want an extension of the compas_cgal.slicer.slice_meshfunction so that I can use it for slicing open and closed meshes.

Details

Currently, the slice_mesh function returns a list of arrays that define the slice polylines. However, there is no information regarding whether the polyline represents an open or a closed contour. Instead, it would be nice if it also returned a boolean for example that defines if the first and the last point of each polyline are connected.

Describe alternatives you've considered We considered having a distance threshold between the first and last points, but that seemed to us impossible to make reliable. So now we consider that all paths are closed, but of course, this limits the shapes that we can apply this method on.

tomvanmele commented 3 years ago

okay will have a look... using a geometric map for the end points should be a good place to start