Fix default acm to empty list if key is present but set to None

[gonzalocasas]

What type of change is this?

• [x] Bug fix in a backwards-compatible manner.
• [ ] New feature in a backwards-compatible manner.
• [ ] Breaking change: bug fix or new feature that involve incompatible API changes.
• [ ] Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• [x] I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
• [x] I ran all tests on my computer and it's all green (i.e. invoke test).
• [x] I ran lint on my computer and there are no errors (i.e. invoke lint).
• [x] I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.Configuration.
• [ ] I have added tests that prove my fix is effective or that my feature works.
• [ ] I have added necessary documentation (if appropriate)

[gonzalocasas]

I think you ought to take a look at robot.py too. inverse_kinematics, etc...

Fixed a bunch more of these here: https://github.com/compas-dev/compas_fab/pull/269/commits/c61ff578328a8b0cf7b233059e3686302d016ff8. I hope that's all of them, I did a regex search across the code base for \.get\(.*,.

[gonzalocasas]

robot.py has the line options.get('attached_collision_meshes', []) in inverse_kinematics, plan_motion and plan_cartesian_motion.

that is fixed already, on the first commit. i think ;)

[beverlylytle]

robot.py has the line options.get('attached_collision_meshes', []) in inverse_kinematics, plan_motion and plan_cartesian_motion.

that is fixed already, on the first commit. i think ;)

oh, some how that wasn't the first diff i was looking at.

[gonzalocasas]

Should I revert the second commit with the various other fixes? It smells like more problems than solutions...

[beverlylytle]

Should I revert the second commit with the various other fixes? It smells like more problems than solutions...

yeah, i think for a hot fix, this is the better option. when there's more time to investigate the other potential sources of bugs, they can be addressed then.

[gonzalocasas]

done! let's see if tests are happy. The robot.py changes should be in. For a proper fix, as you (gladly spotted on time) this needs to be carefully done in all cases were a valid value of the option is a falsy value.

[beverlylytle]

tests are happy!