compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

Add GH components for topic publish and subscribe #300

Closed gonzalocasas closed 2 years ago

gonzalocasas commented 3 years ago

Closes #271 This PR adds two GH components: ROS topic publish, and subscribe.

image

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

gonzalocasas commented 3 years ago

I just discovered an issue with the subscribe component, for some reason, the first subscribe does not work, but if you stop and then start again, then it does. I didn't understand why exactly, so I will check that next week.

beverlylytle commented 3 years ago

Is this ready for review? or is there still a problem with subscribe?