Closed beverlylytle closed 3 years ago
Thanks for fixing the bug!
Given the way mesh.uuid is created (that is, lazily created when guid is called, but not modified when the mesh changes)
Shall we add this case as a warning in the docstring to give the users a heads-up, until we have a better solution for this?
Yes, that makes sense.
Done.
Closes #305 PyBullet, by default, caches the contents of obj's that it has loaded. If it encounters a recognized path to an obj, it assumes the contents are the same as when it first read it. Previously all the meshes were stored in
some/temp/dir/temp.obj
. Now they will be stored insome/temp/dir/{mesh.guid}.obj
. I don't want to disable cacheing entirely, because that would effect performance. I also don't want to return to having a new temp dir every timeconvert_mesh_to_body
is called, because that is essentially turning off cacheing. @gonzalocasas is this sufficient? Given the waymesh.uuid
is created (that is, lazily created whenguid
is called, but not modified when the mesh changes), the problem still exists for the following code:What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_fab.robots.CollisionMesh
.