Following the discussion in the above mentioned issue, I've added a new property unordered_disabled_collisions which is a set of frozensets with the same data as in the usual disabled_collisions which is a set of tuples. This is backward compatible and keeps the existing code clean. Now pybullet_client.disabled_collisions = semantics.disabled_collisions will behave as desired. I didn't add a more broad function to add semantic data to the pybullet client because currently group support in pybullet is a bit hacky and I don't want make it seem otherwise ;)
What type of change is this?
[ ] Bug fix in a backwards-compatible manner.
[x] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[ ] Other (e.g. doc update, configuration, etc)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[ ] I ran all tests on my computer and it's all green (i.e. invoke test).
[x] I ran lint on my computer and there are no errors (i.e. invoke lint).
[ ] I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)
Addresses #318
Following the discussion in the above mentioned issue, I've added a new property
unordered_disabled_collisions
which is a set of frozensets with the same data as in the usualdisabled_collisions
which is a set of tuples. This is backward compatible and keeps the existing code clean. Nowpybullet_client.disabled_collisions = semantics.disabled_collisions
will behave as desired. I didn't add a more broad function to add semantic data to the pybullet client because currently group support in pybullet is a bit hacky and I don't want make it seem otherwise ;)What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_fab.robots.CollisionMesh
.