compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

Adds unordered_disabled_collisions to PyBulletClient and RobotSemantics #319

Closed beverlylytle closed 2 years ago

beverlylytle commented 2 years ago

Addresses #318

Following the discussion in the above mentioned issue, I've added a new property unordered_disabled_collisions which is a set of frozensets with the same data as in the usual disabled_collisions which is a set of tuples. This is backward compatible and keeps the existing code clean. Now pybullet_client.disabled_collisions = semantics.disabled_collisions will behave as desired. I didn't add a more broad function to add semantic data to the pybullet client because currently group support in pybullet is a bit hacky and I don't want make it seem otherwise ;)

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.