compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

yield uniform types in inverse_kinematics #329

Closed beverlylytle closed 2 years ago

beverlylytle commented 3 years ago

Here I've changed the ik backend features to yield the results rather than return them.

One point that is up for discussion still is that robot.inverse_kinematics returns a configuration while client.inverse_kinematics generates tuples of joint value, joint name pairs. This is confusing.

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

gonzalocasas commented 2 years ago

Linked PR: https://github.com/compas-dev/compas_fab/pull/330

gonzalocasas commented 2 years ago

@beverlylytle it looks like this is good to go now, right? Unless you want to make any other changes to it?