compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

fix: `Trajectory` inherits from `Data` to resolve serialization bug with latest compas encoders #360

Closed gonzalocasas closed 2 years ago

gonzalocasas commented 2 years ago

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

gonzalocasas commented 2 years ago

The build fail is totally unrelated, github actions failed to access ROS' wiki/website:

(    backends/ros: line    9) broken    https://www.ros.org/ - HTTPSConnectionPool(host='www.ros.org', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x000001BF3CD08AC0>: Failed to establish a new connection: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond'))

I'll go ahead and merge.