search

compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

Float values as Timeout in move_it_inverse_kinematics.py #373

Closed ebruun closed 1 year ago

ebruun commented 1 year ago

change so floats can be specified as Inverse Kinematic timeout variable

gonzalocasas commented 1 year ago

Hi @ebruun ! Thanks! Although this fix is correct, we think it would be best to actually change the Duration class and allow floats in the `seconds, so that this calculation happens inside the class directly. This means one of the unit tests will need to be adjusted because it currently checks specifically that this is not allowed.

Would you like to give it a show and update this PR with the modification to the Duration class? Also, I would suggest you add yourself to the authors list to credit your contribution.

Cheers!

ebruun commented 1 year ago

got it, just submitted a PR for this!