compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

Compas 2.0.0 incorrectly used for #388

Closed yck011522 closed 9 months ago

yck011522 commented 9 months ago

When running latest CI tests, I noticed the windows-ironpython failed. Upen examination of the error, the cause seems to be that the CI workflow installed compas 2.0.0

From https://github.com/compas-dev/compas_fab/actions/runs/6405579826/job/17388436809?pr=387#step:3:816

Collecting setuptools
Collecting pip
Installing collected packages: setuptools, pip
Successfully installed pip-8.1.1 setuptools-20.10.1
Processing d:\a\compas_fab\compas_fab\compas.tar.gz
Installing collected packages: COMPAS
  Running setup.py install for COMPAS: started
    Running setup.py install for COMPAS: finished with status 'done'
Successfully installed COMPAS-2.0.0a1

I don't know how to fix this. But I think this line needs to point towards a compas >= 1.14 , < 2.0

https://github.com/compas-dev/compas_fab/blob/c3ccdb93c76e21da9c0db7c529b379a328fdff3f/.github/workflows/build.yml#L58C11-L58C15