compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

Retire V-Rrep backend #394

Closed yck011522 closed 6 months ago

yck011522 commented 6 months ago

As discussed in a recent compas_fab upgrade meeting with @gonzalocasas . We are planning to retire the support for V-REP.

I'm starting this PR as a draft to begin the process, but I'm not familiar with the implications when removing this feature. Please help contribute.

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

yck011522 commented 6 months ago

@gonzalocasas

Can you look at how to remove the content of this file: https://github.com/compas-dev/compas_fab/blob/retire_vrep/src/compas_fab/ghpython/path_planning.py)

I think the following functions can be removed:

But what about these classes? Are they reusable for other things?

yck011522 commented 6 months ago

@gonzalocasas Another item for you is how to remove the Black Exclude configuration line here: https://github.com/compas-dev/compas_fab/blob/a75f3e107ab3b9333207fd7572847a3948059f8a/pyproject.toml#L3-L7

yck011522 commented 6 months ago

@gonzalocasas For Github integration, I believe we just remove line 33,34: https://github.com/compas-dev/compas_fab/blob/665a38782fda62dc4ce1c6c5613c7cb67a7b0f7e/.github/workflows/integration.yml#L25-L38

yck011522 commented 6 months ago

@gonzalocasas Overview of remaining files that need to be changed before completing this PR:

One final thing is we need to decide if we want to renumber the folder names and files under docs\example

gonzalocasas commented 6 months ago

For Github integration, I believe we just remove line 33,34:

yes

gonzalocasas commented 6 months ago

@gonzalocasas Another item for you is how to remove the Black Exclude configuration line here:

https://github.com/compas-dev/compas_fab/blob/a75f3e107ab3b9333207fd7572847a3948059f8a/pyproject.toml#L3-L7

You can delete the whole extend-exclude lines

gonzalocasas commented 6 months ago

@gonzalocasas

Can you look at how to remove the content of this file: https://github.com/compas-dev/compas_fab/blob/retire_vrep/src/compas_fab/ghpython/path_planning.py)

I think the following functions can be removed:

  • func vrep_pose_from_plane
  • func _transform_to_origin
  • func _create_rhino_mesh
  • func _to_xform

But what about these classes? Are they reusable for other things?

  • class PathVisualizer
  • class InputParameterParser

Yes, please delete them

gonzalocasas commented 6 months ago

Great! Thanks!

gonzalocasas commented 6 months ago

Ah! Please add yourself to authors.md and then we merge

yck011522 commented 6 months ago

Ah! Please add yourself to authors.md and then we merge

Oh, too late, I'll add it in my next PR.