Closed yck011522 closed 6 months ago
@gonzalocasas
Can you look at how to remove the content of this file: https://github.com/compas-dev/compas_fab/blob/retire_vrep/src/compas_fab/ghpython/path_planning.py)
I think the following functions can be removed:
But what about these classes? Are they reusable for other things?
@gonzalocasas Another item for you is how to remove the Black Exclude configuration line here: https://github.com/compas-dev/compas_fab/blob/a75f3e107ab3b9333207fd7572847a3948059f8a/pyproject.toml#L3-L7
@gonzalocasas For Github integration, I believe we just remove line 33,34: https://github.com/compas-dev/compas_fab/blob/665a38782fda62dc4ce1c6c5613c7cb67a7b0f7e/.github/workflows/integration.yml#L25-L38
@gonzalocasas Overview of remaining files that need to be changed before completing this PR:
One final thing is we need to decide if we want to renumber the folder names and files under docs\example
For Github integration, I believe we just remove line 33,34:
yes
@gonzalocasas Another item for you is how to remove the Black Exclude configuration line here:
You can delete the whole extend-exclude
lines
@gonzalocasas
Can you look at how to remove the content of this file: https://github.com/compas-dev/compas_fab/blob/retire_vrep/src/compas_fab/ghpython/path_planning.py)
I think the following functions can be removed:
- func vrep_pose_from_plane
- func _transform_to_origin
- func _create_rhino_mesh
- func _to_xform
But what about these classes? Are they reusable for other things?
- class PathVisualizer
- class InputParameterParser
Yes, please delete them
Great! Thanks!
Ah! Please add yourself to authors.md and then we merge
Ah! Please add yourself to authors.md and then we merge
Oh, too late, I'll add it in my next PR.
As discussed in a recent compas_fab upgrade meeting with @gonzalocasas . We are planning to retire the support for V-REP.
I'm starting this PR as a draft to begin the process, but I'm not familiar with the implications when removing this feature. Please help contribute.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_fab.robots.CollisionMesh
.