compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.
https://compas.dev/compas_fab/
MIT License
108 stars 32 forks source link

Support compas 2 private Data API #400

Closed yck011522 closed 4 months ago

yck011522 commented 5 months ago

Supporting the new compas 2 private Data API.

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

yck011522 commented 5 months ago

Note to myself that this branch is currently running against compas 2.0.0b4 with an unmerged fix: https://github.com/compas-dev/compas/tree/bugfix/sphere_intersection

compas_robot is still under active fix

yck011522 commented 5 months ago

At the moment, the two failing CI are:

build / windows-ironpython

Need to change workflow to install compas_robots

integration / ubuntu-py38-integration

doctest is failing

=========================== short test summary info ============================
SKIPPED [2] ../../../../../opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/doctest.py:460: all tests skipped by +SKIP option
FAILED docs/examples/03_backends_ros/03_forward_and_inverse_kinematics.rst::line:36,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/03_forward_and_inverse_kinematics.rst::line:49,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/03_forward_and_inverse_kinematics.rst::line:54,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/04_plan_motion.rst::line:23,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/04_plan_motion.rst::line:32,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/05_collision_objects.rst::line:33,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/05_collision_objects.rst::line:50,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/03_backends_ros/05_collision_objects.rst::line:70,column:1 - roslibpy.core.RosTimeoutError: Failed to connect to ROS
FAILED docs/examples/05_backends_pybullet/01_pybullet_examples.rst::line:55,column:1 - AttributeError: 'Color' object has no attribute 'get_urdf_element'

Mostly due to geometry __str__ no longer printing in the same way. Except the case where the error caused by compas_robot : AttributeError: 'Color' object has no attribute 'get_urdf_element'