Remove Legacy - Githubissues

compas-dev / compas_fab

Robotic fabrication package for the COMPAS Framework.

https://compas.dev/compas_fab/

MIT License

108 stars 32 forks source link

Remove Legacy #426

Open yck011522 opened 1 month ago

yck011522 commented 1 month ago

I think it is time to remove the following 4 functions in favor of compas.Data. Especially for the compas_fab 1.0 release.

write_data_to_json
read_data_from_json
write_data_to_pickle
read_data_from_pickle

https://github.com/compas-dev/compas_fab/blob/main/src/compas_fab/utilities/file_io.py#L44-L111

Does anyone have reservations?

yck011522 commented 1 month ago

@gonzalocasas @chenkasirer @romanarust ping.

Any thoughts about the removal of these?

gonzalocasas commented 1 month ago

Agree! Probably read_csv_to_dictionary also needs to go, I don't think it's used currently anywhere in fab, and if it's not, it is not a good place for it as a generic util.