compas-dev / compas_slicer

Slicing package for FDM 3D Printing with COMPAS.
https://compas.dev/compas_slicer/
MIT License
31 stars 16 forks source link

Print organization bug fixes #116

Closed ioannaMitropoulou closed 3 years ago

ioannaMitropoulou commented 3 years ago

In this branch I did the following (also documented in the changelong)

Added:

Changed:

Fixed:

Removed:

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

ioannaMitropoulou commented 3 years ago

Many changes! Generally looks good though! But maybe tomorrow in our meeting you can also take me through some of the changes you did? And I think we should also bump the version with this but we could also do it a next PR.

Sure let's do that! There's actually less changes than it looks, in some files I only mostly changed the indentation from

for layer_key in...
for path_key in ...
for ppt in...

to for ppt in printorganizer.printpoints_iterator

But then the change appears as if I have changed the entire file :/

I'll show you tomorrow what I did exactly