compas-dev / compas_slicer

Slicing package for FDM 3D Printing with COMPAS.
https://compas.dev/compas_slicer/
MIT License
31 stars 16 forks source link

Alternative unions #133

Closed ioannaMitropoulou closed 3 years ago

ioannaMitropoulou commented 3 years ago

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

joburger commented 3 years ago

looks good! just a small comment, before when I had to use a 'very big number' I used 2 ** 32, maybe for consistency should we just always use that when we need a very high number?