Closed Licini closed 2 years ago
@Licini any updates here?
Since this involves some API changes, so I think it's better to not yet merge today but examine it more carefully then put into next release ( in very near future tho )
@brgcode Just cleaned up what's left, Can we take another look on this now? (would need to merge this first https://github.com/compas-dev/compas/pull/1062)
Might look like a whole lot of changes, but the core purpose of this PR is really just:
BufferObject
to the baseObject
, and explicitly define them atviewer.add()
, so that at user level, people will be able to see all acceptable parameters through pylance.Some other smaller changes are:
show_vertices
,show_edges
,color
andsize
. Following visualisation parameters now apply universally across all object types:show_points
,show_lines
,show_faces
,pointcolor
,linecolor
,facecolor
,pointcolors
,linecolors
,facecolors
,pointsize
,linewidth
.Color
class when applicable.Collection
class, seescripts/v120_collections.py
.To discuss:
u
,v
forSphereObject
, should we treat them as additional kwargs or a seperate dict?