compas-dev / compas_view2

Standalone viewer for COMPAS
https://compas.dev/compas_view2/
MIT License
6 stars 8 forks source link

Config integration rebased #185

Closed ZacZhangzhuo closed 10 months ago

ZacZhangzhuo commented 10 months ago

What type of change is this?

ZacZhangzhuo commented 10 months ago

Thanks, @Licini for the comments! This PR should resolve most of the points you pointed out.

Changes

Questions

Maybe we need a discussion about it. :)

Thanks anyway!

Licini commented 10 months ago

Hey Zac, I might have confused you, what I meant was to rebase your branch to the latest main on the official remote. There is no need for making a separate PR for this. : )

In this way the file change history on #184 will update to exclude the content from the last merged PR. Currently you rebased on the main of your own fork, which was not up-to-date.

image