Closed ZacZhangzhuo closed 10 months ago
Thanks, @Licini for the comments! This PR should resolve most of the points you pointed out.
helper
folder is not useful at least for now, and I have deleted it.action
folder a bit. The functions like mouse_key_check()
are now in the action.py
, which makes more sense to me. one PR solves one problem
. In this case, we aim for a major release, so the files are many. How could we break them then?main
. But, I also found sometimes the linear development
is important. For example, I must develop the custom-keys
pr after I finish the configure-the-settings
pr first and develop upon it. Also this may prevent potential issues when you merge.Maybe we need a discussion about it. :)
Thanks anyway!
Hey Zac, I might have confused you, what I meant was to rebase your branch to the latest main on the official remote. There is no need for making a separate PR for this. : )
In this way the file change history on #184 will update to exclude the content from the last merged PR. Currently you rebased on the main of your own fork, which was not up-to-date.
What type of change is this?
rebased
branch ofconfig-integration
referred to pr #184 so it is not mixed with theexample-files
branch.