Align all sceneobject parameters and move to COMPAS core

compas-dev / compas_viewer

Standalone viewer for COMPAS with PyOpenGL and PySide6.

http://compas.dev/compas_viewer/

Other

1 stars 2 forks source link

Align all sceneobject parameters and move to COMPAS core #174

Open Licini opened 1 month ago

Licini commented 1 month ago

@tomvanmele since you are already making several PRs on Scene Objects, shall we make a list about all the visualization parameters for objects and consolidate them into COMPAS core? So that ideally we don't need to define any of them in viewer

tomvanmele commented 1 month ago

yes that would be great. there are still quite few things that could be generalised and streamlined...

PingHsunTsai commented 1 month ago

base on the modification here. I think it will be good to add

self.highlight_color = Color.yellow()
self.selected = False

self.line_width = 1.0
self.point_size = 1.0

tomvanmele commented 1 month ago

i have the following notes:

all visualisation parameters should be moved to compas.scene.SceneObject
for default colors we should use the defaults of the visualisation context. therefore default values of ColorAttribute should be None.
viewer and notebook viewer contexts should have a global default for color values, which is used if no specific value is provided by the user. in the case of a CAD environment, we use the default of the CAD environment.
surfacecolor shoould be facecolor.