compassion-global-experience / compassion-design-system

Compassion International's Global Design System
https://designwithcompassion.com
MIT License
6 stars 6 forks source link

Checkbox can only be deselected via its label #183

Open kendrick opened 1 year ago

kendrick commented 1 year ago

The check icon is placed higher in the stacking context than the checkbox itself. This means that, after being selected, the checkbox cannot receive a click event unless its label is clicked.

Export-1691768881307

kendrick commented 1 year ago

cf. these lines in core: https://github.com/compassion-global-experience/compassion-design-system/blob/49b1fc8cdfc5c6e688b3b153543729856cf4aed4/packages/core/src/components/Form/Checkbox.stories.js#L35

… and react: https://github.com/compassion-global-experience/compassion-design-system/blob/49b1fc8cdfc5c6e688b3b153543729856cf4aed4/packages/react/src/components/Form/ChoiceInput.tsx#L38