search

compbio-UofT / medsavant

MedSavant is a search engine for genetic variants
22 stars 9 forks source link

jannovar should be updated #335

Open jvlasblom opened 10 years ago

jvlasblom commented 10 years ago

Jannovar has had several updates posted on the git repository https://github.com/charite/jannovar.git

(This is Peter Robinson's repository, we don't have/want write access to it).

We've absorbed the Jannovar source code as a subproject of medsavant (in subdir medsavant/jannovar) as of late-march. The changes posted to https://github.com/charite/jannovar.git since then should be merged in with our own changes.

meatcar commented 10 years ago

What really should be done, is Jannovar should be forked under the compbio-UofT organization, and that fork should be used either as a git submodule, or a maven dependency when building medsavant. That way, any changes we make to Jannovar could be potentially pushed upstream (i.e. logging) via pull requests, while updates upstream can be easily merged into our version.

meatcar commented 10 years ago

Jannovar has forked to https://github.com/compbio-UofT/jannovar, Changes in the jannovar folder have been added to the fork as individual commits.

Next Steps: