With data-xid comments don't require social login

[raulsperoni]

Hi, I've set up a poll with the option "Participants cannot submit comments without first connecting either Facebook or Twitter" checked, but when I set data-xid parameter in iframe parent div pol.is submits new comments without requiring social login.

If I remove data-xid={"hola"} everything work as expected.

<div
        id="polisDiv"
        className="polis"
        data-conversation_id={conversationId}
        data-xid={"hola"}
      ></div>

I tried this with my own pol.is deployment and with the cloud one.

Is this the correct behaviour?

https://github.com/compdemocracy/polis/discussions/1120#discussioncomment-1288156

Thank you.

[metasoarous]

Thanks for submitting @raulsperoni.

As written, the functionality of the toggle does not perfectly match it's description. That having been said, I think the intent of the functionality is that some form of identity be required for comment submission, whether via social login or xid. So there's a few ways this could go:

1. clarify the description of the toggle
2. modify the functionality of the toggle to match the current description
3. add more nuanced toggles for requiring some form of identity versus specifically requiring social login

There are some nontrivial implications to consider with respect to this decision.

[raulsperoni]

An update on this: If some user answers more than (five? not sure) social login buttons appears below the cards and works. After the redirect (twitter for example) the photo is shown in the visualization, and the comments can be sent as that user.

[metasoarous]

Yes; It still presents an option to connect social, but it isn't mandatory. Sorry if that wasn't obvious.

Does that more or less solve the issue for you as far as you're concerned?

Thanks