compdemocracy / polis

:milky_way: Open Source AI for large scale open ended feedback
https://pol.is
GNU Affero General Public License v3.0
738 stars 172 forks source link

Social media logins don't work on embedded conversations #1549

Open robgitnyc opened 1 year ago

robgitnyc commented 1 year ago

Hi.

Upon failing to deploy my own instance of pol.is (https://github.com/compdemocracy/polis/discussions/1548) I tried to make pol.is work embedded in a simple html page, however upon trying to comment, social media logins don't work. Facebook says "facebook doesn't support this app" and twitter does log in but something happens that immediately goes back to "unlogged" state.

Help would be greatly appreciated. Thank you

patcon commented 1 year ago

Ah shoot, that's unexpected to me...!

Might you be able to confirm that social media login features work fine when not embedded?


As an aside, if something did break that's related to us (and not changing web standard), then we might be able to catch these things with e2e tests for facebook login functionality. Will make a note there, as I don't think I considered that embedded and non-embedded should be tested separately. https://github.com/compdemocracy/polis/issues/541

robgitnyc commented 1 year ago

Ah shoot, that's unexpected to me...!

Might you be able to confirm that social media login features work fine when not embedded?

As an aside, if something did break that's related to us (and not changing web standard), then we might be able to catch these things with e2e tests for facebook login functionality. Will make a note there, as I don't think I considered that embedded and non-embedded should be tested separately. #541

Social media logins work when login from the main server at pol.is. However with conversations embedded in a separate webpage (for instance a live github pages site), social media logins don't work.

JosephGubbels commented 11 months ago

Having this same issue. The Facebook login also seems to be broken even on pol.is (i.e. non-embedded). The button will appear, but won't work.

hugetim commented 10 months ago

I'm having the same experience. Facebook button is non-functional (nothing happens when clicking it) on the pol.is url.