Move to Prettier

[misscs]

Vision

Offload code styling to Prettier so we can focus on the good stuff

To Do

• [x] client-admin #386
• [ ] client-report
• [ ] client-participation
• [x] server #988

[colinmegill]

👍🏻 On Sun, Oct 1, 2017 at 11:24 AM claudina sarahe notifications@github.com wrote:

Vision

Offload code styling to Prettier https://github.com/prettier/prettier so we can focus on the good stuff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pol-is/issues/issues/68, or mute the thread https://github.com/notifications/unsubscribe-auth/ABsDGQFI6Iv6bBRszXwqpG2TQwwky2Iuks5sn9jbgaJpZM4Pp-xC .

[patcon]

So much yes!

GitHub released a big omni-linter today, and the top comment on Hacker News was:

After using Prettier for a few years I'm firmly in the camp of mandatory/enforced code formatters. As long as it's a half decent formatter like Prettier I believe my personal opinions on the specific formatting choices are much less important than essentially never having to think about formatting again, in particular having to ask people to fix formatting in code reviews (or fix it myself).

What say we run an aggressive prettier run against the codebase and get on this train? Someone else can make all the decisions on settings, or I'll happily take the default, but let's not be laissez-faire pls :slightly_smiling_face:

This plugins can add easily-mergeable suggestion comments in PRs, based on results of diff after some sort of fix command has been run: https://github.com/r7kamura/danger-suggester

cc @metasoarous

EDIT: spawned #502

[patcon]

Yes!

I feel in agreement with this top comment in today's hacker news post about github's new linter:

my personal opinions on the specific formatting choices are much less important than essentially never having to think about formatting again,

This could be helpful: a GitHub action to help run danger (which makes inline comments), and this danger plugin that makes those comments with suggestions from a diff:

• https://danger.systems/js/
• https://github.com/MeilCli/danger-action
• https://github.com/r7kamura/danger-suggester

So any "fix" tool can be converted into easily-mergeable suggestions :)

[patcon]

This is now done for client-admin #386 🎉

[patcon]

Another option for auto-suggesting fixes for automated review: ReviewDog.

• https://github.com/reviewdog/reviewdog#reporter-github-pullrequest-review-comment--reportergithub-pr-review
• https://github.com/reviewdog/action-suggester

danger requires ruby, and this just need go binaries.

EDIT: +1 from @colinmegill and chris for auto-suggest: https://github.com/pol-is/polis/pull/673#issuecomment-741561548

[micahstubbs]

will send a PR to do this for server presently