search

compdemocracy / polis

:milky_way: Open Source AI for large scale open ended feedback
https://pol.is
GNU Affero General Public License v3.0
753 stars 173 forks source link

translate client-admin file to Traditional Chinese #1742

Open mashbean opened 10 months ago

mashbean commented 10 months ago

Translate the en_us.js from client-admin to Traditional Chinese zh_hant.js

ebarry commented 10 months ago

Thank you for contributing this @mashbean !!!

metasoarous commented 10 months ago

Hi @mashbean. Thanks again for submitting this!

I investigated a bit further, and confirmed that these "strings" files aren't actually hooked up by default the same way they are in the client-participation part of the codebase. I think the client-admin/src/pt_br.js file was submitted assuming that you would manually swap it out for the en_us.js file in client-admin/src/strings/strings.js. In fact you'll see a TODO note there about porting over the browser language detection code from client-participation.

Right now, there's no harm in me merging this as is, so it can be swapped out for en_us with a deploy code change (as with pt_br). But I figured I'd give you the chance to adapt the browser detection logic from client-participation, if you'd like this to be automated.

Please let me know which way you'd like to go on this :-)

Thanks again!

mashbean commented 10 months ago

Hi metasoarous, I've received the mail and message. Thank you so much for correcting my error. If there are more traditional Chinese translation demands, please feel free to tag me! I am glad to be the contributor for Polis