compdemocracy / polis

:milky_way: Open Source AI for large scale open ended feedback
https://pol.is
GNU Affero General Public License v3.0
741 stars 172 forks source link

Unmoderated statement available for self-voting #445

Open patcon opened 4 years ago

patcon commented 4 years ago

I'm observing some unexpected behavior when submitting a statement to a convo that I don't admin, when its under strict moderation. I am being presented with the ability to vote on my submitted statement, even when it isn't yet cleared.

Steps to reproduce

  1. Open any conversation with strict moderation, e.g. https://pol.is/3ntrtcehas
  2. Submit a statement below
  3. Visit the comment moderation admin UI for that convo, e.g. https://pol.is/m/3ntrtcehas/comments (screenshot)
    • note that the comment is unmoderated
    • being able to access this admin UI is a bug that's under review #418 (fixing the bug will not resolve root issue)
  4. Visit participation link again, and vote on statements until you see...

Expected result

My unmoderated submission would never show up.

Observed result

My unmoderated comment does show up for voting. (screenshot)

Unresolved Questions

cc: @colinmegill

patcon commented 4 years ago

validated this with @metasoarous on a call. seems odd, not sure if bug. Confirmed that it's only for admins who can see and vote on comments in their logged in client-participation view, even though comment state is unmoderated

Chris says that "this will not affect math, as a submission gets one vote anyhow -- we already deal with this and are robust to this."

Assumes this is bug, but need @colinmegill's second opinion