compdemocracy / polis

:milky_way: Open Source AI for large scale open ended feedback
https://pol.is
GNU Affero General Public License v3.0
773 stars 178 forks source link

Add E2E tests for Facebook login #541

Open patcon opened 4 years ago

patcon commented 4 years ago

Re-ticketed from https://github.com/pol-is/polis/pull/527 https://github.com/pol-is/polis/pull/523 (🎉 @patrickas )

It seems like there are some issues with Facebook login flows, that are hard to sort. I'd like to start adding E2E Cypress tests to ensure these flows aren't breaking.

Current blocks to allowing this:

Resources

patcon commented 3 years ago

A contributor has recently added Facebook Login support to this Cypress plugin that supports third-party login support: https://github.com/lirantal/cypress-social-logins

(normally, cypress is not designed to work within urls outside the site domain)

EDIT: working through how to get this going https://github.com/lirantal/cypress-social-logins/pull/67

patcon commented 2 years ago

As noted in https://github.com/compdemocracy/polis/issues/1549#issue-1408752578, it's perhaps good to also test facebook login (and social login generally) both within iframes (embedded) and directly on the site. It seems that social login for embedded convos might break when it otherwise works.