compdemocracy / polis

:milky_way: Open Source AI for large scale open ended feedback
https://pol.is
GNU Affero General Public License v3.0
723 stars 171 forks source link

Add <title> to Polis conversation pages #70

Open patcon opened 4 years ago

patcon commented 4 years ago

Right now, the <title></title> HTML tag shows up as empty, and so the raw url shows up in browser tab and browser bookmarks.

The title should instead be something like Conversation - What are your feelings on President Oprah 2020? - Polis

Example: https://pol.is/3ntrtcehas

Screenshot

Screen Shot 2020-05-03 at 10 16 33 PM

Potential labels: client-participation, first-timers-only

patcon commented 4 years ago

Seems the default title it "Polis", which flickers for a second on reload before getting removed. Seems this might be where this happens -- not sure why this happens:

https://github.com/pol-is/polisServer/blob/5ac29b7245a7b198e40d1727ea246ed25acfecb7/client-participation/js/main.js#L374-L376

(window.location.port is an empty string.)

This sort of thing would make an excellent first pull request for a newcomer!

vvkpd commented 3 years ago

I would like to work on this card, could you please assign to me? Thanks!

patcon commented 3 years ago

Yay! Thanks @vvkpd! Done and done! 🎉

Lemme know in Gitter if you have any questions, or feel free to bring them to the open call on the weekend (happy to meet a bit earlier that day if after midnight is tough for Bangalore 🙂 )

vvkpd commented 3 years ago

Thanks for assigning me on this task. I will start working on it. Just a small suggestion: Could you please add hacktoberfest topic to repo and hacktoberfest as label in this task? Background: I am participating in hacktoberfest 2020. Thanks

patcon commented 3 years ago

Done! Thanks!