Migrate bower/gulp scripts to webpack

[metasoarous]

OMG; So old. Much problems.

To Do

• [x] client-admin: gulp
• [x] client-participation
  • [x] remove bower https://github.com/pol-is/polis/pull/734
  • [x] upgrade webpack https://github.com/pol-is/polis/pull/744
  • [x] move gulp tasks to webpack
  • [x] remove grunt
• [ ] client-report: gulp

[patcon]

@colinmegill (https://github.com/pol-is/polis-issues/issues/139#issuecomment-622588628) and @metasoarous (gitter chat) still favouring webpack.

[colinmegill]

+1 fully removing bower in favor of webpack.

On Sat, May 2, 2020 at 7:42 PM Patrick Connolly notifications@github.com wrote:

@colinmegill https://github.com/colinmegill (pol-is/polis-issues#139 (comment) https://github.com/pol-is/polis-issues/issues/139#issuecomment-622588628) and @metasoarous https://github.com/metasoarous (gitter chat https://gitter.im/pol-is/polisDeployment?at=5eaddd7eadb0ec5c2bdf0e2f) still favouring webpack.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pol-is/polisClientParticipation/issues/34#issuecomment-623030068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANQGGL6U2SKNQUJNKJHUT3RPSVXLANCNFSM4FY2A3JQ .

[patcon]

I'm assuming this involves ditching gulp as well, right? (the "etc" bit)

or is that a separate task?

[colinmegill]

Correct. Also means getting off handlebars and backbone.

On Thu, May 7, 2020, 12:26 AM Patrick Connolly notifications@github.com wrote:

I'm assuming this involves ditching gulp as well, right? (the "etc" bit)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pol-is/polisClientParticipation/issues/34#issuecomment-625021801, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANQGGON4CZRU6HXILDMT6TRQI2ALANCNFSM4FY2A3JQ .

[patcon]

colin suggested MVP can just be to vendor all the bower deps by adding them into git

[patcon]

Once we ditch or update gulp beyond v4, then we can also update client-* components beyond node 11.x, maybe all the way to 14.x like the rest of project. See https://github.com/pol-is/polisServer/pull/327#issuecomment-644470870 https://github.com/pol-is/polis/issues/346#issue-641519032

[patcon]

Here's some research onto the best tools to use to ditch gulp for webpack:

gulp	webpack
gulp-s3	s3-plugin-webpack
rimraf	clean-webpack-plugin
gulp-gzip	compression-webpack-plugin
gulp-scp2	webpack-scp-upload-plugin

[patcon]

Some of this is getting done while making a demo for how a dev framework like create-react-app could be implemented, but since webpack migration is less controversial, could extract that: https://github.com/pol-is/polis/pull/515

EDIT: Trying to get it working without the dev framework, but something is going wrong and I can't quite figure it out: https://github.com/pol-is/polis/compare/create-react-app...patcon:webpack-only

[patcon]

Working on bower->webpack for client-participation. Current notes:

• installing all bower packages with npm instead
• changing all paths in gulpfile to browserify from node_modules instead of bower_components
• d3-tip@v0.6.4 lacks a package.json, so upgrading to v0.6.7 (which is on npm already) diff
• using bootstrap-sass instead of bootstrap-sass-official, which is the same, but some sort of folder reorganization
• deepcopy.min.js doesn't exist in npm package, just deepcopy.js (uglify runs after anyhow)
• ...

EDIT: details in #734

[patcon]

Migrating gulp => webpack in https://github.com/compdemocracy/polis/pull/1242

(@metasoarous if you could link that issue into the top-level issue checklist, that'd be rad 🙏 )

[ballPointPenguin]

See https://github.com/DFE-Digital/polis-whitelabel/pull/38 for inspiration