search

compdyn / partmc

Particle-resolved stochastic atmospheric aerosol model
http://lagrange.mechse.illinois.edu/partmc/
GNU General Public License v2.0
28 stars 16 forks source link

Add user selection of weight scheme #61

Closed jcurtis2 closed 7 years ago

jcurtis2 commented 7 years ago

Addresses #7 and replaces #55

jcurtis2 commented 7 years ago

Is this how we want to do this? Currently this code requires the user to always specify the weighting scheme. There is potentially another way to do this.

It may be preferred to hide this from the general user. This could be done with a logical variable (similar to how we have do_coagulation we would have a do_weight_selection) that can set to true/false for user selection of weighting scheme. Typically this variable would be set to false and the default weighting scheme would be used. In the case where we might want to switch the weighting scheme, we then set it to true. In this case, the user would specify the weight type (and exponent if power weighting).

jcurtis2 commented 7 years ago

Added a line to the spec file whether or not the user wants to pick the weighting scheme. This is typically set to no and then the simulation proceeds using the current default weighting scheme of nummass_source.