search

compdyn / partmc

Particle-resolved stochastic atmospheric aerosol model
http://lagrange.mechse.illinois.edu/partmc/
GNU General Public License v2.0
28 stars 16 forks source link

added retries to tests #64

Closed mattldawson closed 3 years ago

mattldawson commented 6 years ago

Added 10 retries for each integration test in their bash scripts. If tests fail in the future, it may be because the retry loop is not rerunning all the analyses from previous tests that the current (failing) test depends on.

mwest1066 commented 3 years ago

I inadvertently duplicated this functionality in #154. See #154 for a long discussion thread on the slightly different approaches used in the two PRs. I eventually merged #154 because it fits slightly better with the way I develop/debug tests. Because of that merge I will now close this PR.

@mattldawson double-apologies again for the fact that I ignored your code and then you had to explain it all to me! I feel so bad about this!

mattldawson commented 3 years ago

no problem at all =) - it at least led to a fun hyper-specific discussion! i feel like i have several more important points to make about things that matter almost not at all

mwest1066 commented 3 years ago

no problem at all =) - it at least led to a fun hyper-specific discussion! i feel like i have several more important points to make about things that matter almost not at all

Hahaha, love it 😄