Avoid hard-coded values on reaction defines

[cguzman95]

There are hardcoded values in each rxn_ file like:

define NUM_INTPROP 2

define NUM_FLOATPROP 7

and some -1 and others. Improve indices like NUMREACT and NUM_PROD to sum this data and have fewer indices if it's possible, otherwise, put NUM_INTPROP and the others inside RXN, on the integer reaction part

[mattldawson]

hi @cguzman95 - these will go away entirely after the somewhat mythical version 2.0. Can we put this off until then? these indices are already very difficult to maintain and I'm not convinced this would provide much of a performance increase. close if you agree

[cguzman95]

Yep, this is for version 2.0. We will see how this is working on 2.0, so at the moment it's unimportant