search

compdyn / partmc

Particle-resolved stochastic atmospheric aerosol model
http://lagrange.mechse.illinois.edu/partmc/
GNU General Public License v2.0
28 stars 16 forks source link

GPU: Fix RXN sorting #98

Closed cguzman95 closed 4 years ago

cguzman95 commented 5 years ago

I was testing a GPU optimization of sorting the rxn data at the start, starting RXN by reactions with "few zeros" to reactions with "a lot of zeros".

The sort was correct, but the program crashes. I RECENTLY NOTICED that rate_constants needs to be sorted following the RXN order to follow consistence. It's pending fixing this rate_constants and testing if this fixes the issue.

cguzman95 commented 4 years ago

Update: Seems no improving doing this for GPU (same time execution)

mattldawson commented 4 years ago

should we close this then? we've removed the rate constants array as well

cguzman95 commented 4 years ago

Well we removed rate constants and added rxn_env so it's even more complicated (I only update the order of rxn_env_idx, but it could be better if I could update rxn_env). I still thinks could be nice for the base version (cpu), but in any case it would be re-taked in the distant future, and this issue is for the GPU case. So I will close this