Closed cguzman95 closed 4 years ago
Update: Seems no improving doing this for GPU (same time execution)
should we close this then? we've removed the rate constants array as well
Well we removed rate constants and added rxn_env so it's even more complicated (I only update the order of rxn_env_idx, but it could be better if I could update rxn_env). I still thinks could be nice for the base version (cpu), but in any case it would be re-taked in the distant future, and this issue is for the GPU case. So I will close this
I was testing a GPU optimization of sorting the rxn data at the start, starting RXN by reactions with "few zeros" to reactions with "a lot of zeros".
The sort was correct, but the program crashes. I RECENTLY NOTICED that rate_constants needs to be sorted following the RXN order to follow consistence. It's pending fixing this rate_constants and testing if this fixes the issue.