search

compgeolab / eql-gradient-boosted

Paper: Gradient-boosted equivalent sources method for interpolating very large gravity and magnetic datasets
https://doi.org/10.31223/X58G7C
BSD 3-Clause "New" or "Revised" License
19 stars 6 forks source link

Review the results once more #162

Closed leouieda closed 3 years ago

leouieda commented 3 years ago

Making small touches to the text to make sure we don't miss anything.

github-actions[bot] commented 3 years ago

:robot: :wave: Hi there, human. It looks like you're editing the manuscript. I'll build it for you whenever you make changes and place the resulting PDF at: https://github.com/compgeolab/eql-gradient-boosted/blob/preview-pr162/preprint.pdf You can see the resulting PDF of the GJI version of the manuscript at: https://github.com/compgeolab/eql-gradient-boosted/blob/preview-pr162/gji.pdf

The preview branch preview-pr162 will be deleted when the PR is closed/merged.

leouieda commented 3 years ago

Has the commits from #161 for now. Will rebase once that is merged.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

leouieda commented 3 years ago

@santisoler finished the results but couldn't get to the discussion in time, sorry.

I made some tweaks to the figures and the text but again nothing major. Feel free to make any changes you see fit and merge when ready!

I'll finish revising as soon as I get back from vacation (or sooner if I get bored 🙂).

santisoler commented 3 years ago

@santisoler finished the results but couldn't get to the discussion in time, sorry.

Thanks! Don't worry for the discussion, we can do that later.

I made some tweaks to the figures and the text but again nothing major. Feel free to make any changes you see fit and merge when ready!

:+1:

I'll finish revising as soon as I get back from vacation (or sooner if I get bored slightly_smiling_face).

I forbid you. I won't merge any PR you make until you come back from the vacations. And I'll be watching commit datetimes on any PR you open later on :eyes: Enjoy!

leouieda commented 3 years ago

TODO:

leouieda commented 3 years ago

@santisoler I reverted the cmap back to viridis, made the cmap of the random vs sequential figure the same as the difference figures, and made the Australia CV figure into a single column instead of full width. See what you think and if you're happy, then please merge away. I'll look at the discussion in another PR.

santisoler commented 3 years ago

Awesome! I'm merging this! Thanks a lot!