Dynamically created elements are not localized dynamically

comphist / cora

A web-based, token-level annotation tool for non-standard language data

http://www.linguistics.rub.de/comphist/resources/cora/

MIT License

10 stars 6 forks source link

Dynamically created elements are not localized dynamically #58

Closed mbollmann closed 7 years ago

mbollmann commented 8 years ago

Originally reported by: Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann)

HTML elements that are created dynamically from JavaScript are not localized immediately after switching languages, since they have already been created and are missing a "data-trans-id" attribute.

This affects for example:

Dropdown menu in editor table
Some dialog windows (e.g. search dialog)

Two possible solutions to this problem:

Add a "data-trans-id" attribute when creating HTML elements directly from JavaScript; this should work for the first case (dropdown menu in editor table).
Recreate the affected dialogs when switching languages (e.g., we could probably just re-instantiate cora.editor.tokenSearcher to update the search dialog)

Bitbucket: https://bitbucket.org/mbollmann/cora/issue/55

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Move dialog title to PHP template, re issue #55

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Fix locale changing of dropdown menu, re issue #55

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Fix locale changing of edit tab dialogs, re issue #55

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Between this and issue #61, it looks like all affected elements have been fixed for now, even if they could be refactored further. Closing for now.

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Move dialog title to PHP template, re issue #55

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Fix locale changing of dropdown menu, re issue #55

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Fix locale changing of edit tab dialogs, re issue #55

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

@fsimonjetz creates an overview of affected elements; we postpone the final decision until we know all the elements that are actually affected.