search

comphist / cora

A web-based, token-level annotation tool for non-standard language data
http://www.linguistics.rub.de/comphist/resources/cora/
MIT License
10 stars 6 forks source link

Localization of the placeholder in the search form #61

Closed mbollmann closed 7 years ago

mbollmann commented 8 years ago

Originally reported by: fsimonjetz (Bitbucket: fsimonjetz, GitHub: Unknown)

The placeholder ("(leer)") in the search form on the editor tab is localized correctly at language change, however when new search options are added by using the plus button on the right side, the placeholder in the new search form will remain unlocalized unless the page is reloaded (cf. commit 6738138).

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Since commit b85190d, the search dialog gets rebuilt when the locale changes, resolving this problem.

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

This is because the template (containing the placeholder) is stored in a class variable of FlexRowList, where it doesn't get updated when the language changes.

Maybe whatever class is responsible for this FlexRowList needs to be called on language change to update it?