Forms on the Admin tab do not get localized

comphist / cora

A web-based, token-level annotation tool for non-standard language data

http://www.linguistics.rub.de/comphist/resources/cora/

MIT License

10 stars 6 forks source link

Forms on the Admin tab do not get localized #64

Closed mbollmann closed 7 years ago

mbollmann commented 8 years ago

Originally reported by: Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann)

Originally reported by @fsimonjetz in issue #60:

the forms for adding projects, tagset browser and importing tagsets do not get localized, I have no clue why - the other strings in the same file (admin.js) work fine.

Bitbucket: https://bitbucket.org/mbollmann/cora/issue/61

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Fix locale changing in admin tab dialogs, resolving #61

Not much refactoring or unification in the way dialog boxes are created has been done yet, since this seems to be a larger (and different) issue.

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Fix locale changing in admin tab dialogs, resolving #61

Not much refactoring or unification in the way dialog boxes are created has been done yet, since this seems to be a larger (and different) issue.

mbollmann commented 8 years ago

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):

Reason: They are initialized before the locale file is loaded from the server, so the localization function returns empty strings.

The affected forms are created differently than the others, probably unnecessarily so. Seems like refactoring things would result in nicer code as well.