search

comphist / cora

A web-based, token-level annotation tool for non-standard language data
http://www.linguistics.rub.de/comphist/resources/cora/
MIT License
10 stars 6 forks source link

Fix line jumper #99

Closed mbollmann closed 7 years ago

mbollmann commented 7 years ago

Fixes a bug with the line jumper dialog box that was probably introduced in b85190d; namely, when the line jumper class is re-initialized, its contents are moved over to the new instance, leaving the old instance content-less.

This happens, for example, when starting a search or changing the language.

codecov[bot] commented 7 years ago

Codecov Report

Merging #99 into master will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
+ Coverage     29.97%   29.99%   +0.01%     
  Complexity     1333     1333              
============================================
  Files            63       63              
  Lines          7405     7405              
============================================
+ Hits           2220     2221       +1     
+ Misses         5185     5184       -1
Flag Coverage Δ Complexity Δ
#backend 52.37% <ø> (ø) 1333 <ø> (ø) :arrow_down:
#frontend 0.56% <ø> (+0.03%) 0 <ø> (ø) :arrow_down:
Impacted Files Coverage Δ Complexity Δ
src/gui/js/edit/LineJumper.js 34.78% <ø> (+34.78%) 0 <0> (ø) :arrow_down:
src/gui/js/tagsets/Tagset.js 0% <0%> (-28.89%) 0% <0%> (ø)
src/gui/js/tagsets.js 0% <0%> (-6.39%) 0% <0%> (ø)
src/gui/js/gui.js 3.42% <0%> (+3.42%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcfd6ce...4e4835e. Read the comment docs.