search

compilatio / moodle-plagiarism_compilatio

Compilatio.net plagiarism plugin for Moodle
4 stars 9 forks source link

amd/build/*.js should contains min #35

Open cperves opened 4 years ago

cperves commented 4 years ago

while running unit tests , there is an error concerning compilatio plagiarism plugin 

2) core_requirejs_testcase::test_requirejs
Failed asserting that '/var/www/moodle_layerunistra35/plagiarism/compilatio/amd/build/ajax_api.js' contains ".min".

/var/www/moodle_layerunistra35/lib/tests/requirejs_test.php:91
/var/www/moodle_layerunistra35/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit "core_requirejs_testcase" lib/tests/requirejs_test.php

If you minify your amd/src/ajax_api.js with grunt you'll have the correct ajax_api.min.js placed in amd/build directory and then pass unit test

Regards Céline Pervès

ndunand commented 3 years ago

Hello,

It seems the .min files are present now.

However, related to this issue, the following map files are missing:

build/compilatio_ajax_api.min.js.map
build/compilatio_form.min.js.map

This can easily be corrected by running grunt amd in the plugin's directory. Official documentation: https://docs.moodle.org/dev/Grunt#Running_grunt .